Validator cut [WIP] #2052
Validator cut [WIP] #2052
Conversation
open-junius
added
the
skip-cargo-audit
|
Where are these coming from? Two days ago, we were enabling a childkey recycling of 18%, then it was cancelled. Now placing vali dividends in subnet hands? Is there any public discourse on this? |
pallets/subtensor/src/lib.rs
Outdated
| #[pallet::type_value] | ||
| /// Default validator cut 50% | ||
| pub fn DefaultValidatorCut<T: Config>() -> u16 { | ||
| u16::MAX / 2 |
There was a problem hiding this comment.
this should default to 100% else you're just forcing a massive change on all the subnet owners
There was a problem hiding this comment.
The cut is rate of split between validators and miners. You can check code in line 669. If it is 100%, miners get nothing.
There was a problem hiding this comment.
You’re right that makes sense, I misunderstood the default setting.
It helps shitnets prop up their token prices. |
|
@open-junius is there a limit to how high the cut can be? There should be. |
|
|
There are 2 places in run coinbase where the vali/miner ratio is mentioned. You got the div(2), but missed the multiply(0.5) Please look at line 211, and update that as well. |
It is for the root alpha, I am not sure if the cut also should be applied to it. will clarify the requirement. Thank for point it out. |
if you don't account for it - the incorrect amount of alpha will be deducted for the root stakeholders, and the math won't sum correctly. it will also let us close an issue: |
This was not answered specifically, nor was this communicated to be included soon. |
Description
It will allow the subnet owner to set the validator cut during emission.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.